[Buildroot] [PATCH 1/1] package/acpid: fix acpid.service permissions

James Hilliard james.hilliard1 at gmail.com
Wed Dec 12 09:00:04 UTC 2018


On Wed, Dec 12, 2018 at 1:55 AM Arnout Vandecappelle <arnout at mind.be> wrote:
>
>  Hi James,
>
> On 12/12/2018 03:20, james.hilliard1 at gmail.com wrote:
> > From: James Hilliard <james.hilliard1 at gmail.com>
>
>  Could you give a little more detail here? In particular: is it just because
> it's not supposed to be executed, or does it in fact give some runtime problems
> if it is executable? That information is important to decide if the patch should
> be backported to the stable branches or not.
It causes systemd to throw runtime warnings since systemd service
files are essentially a type of configuration file and are not
designed to be executed like init scripts. You should probably
backport it to get rid of the noise in the logs it causes.
>
>  Regards,
>  Arnout
>
> >
> > Signed-off-by: James Hilliard <james.hilliard1 at gmail.com>
> > ---
> >  package/acpid/acpid.mk | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/acpid/acpid.mk b/package/acpid/acpid.mk
> > index 514fd31..adcc175 100644
> > --- a/package/acpid/acpid.mk
> > +++ b/package/acpid/acpid.mk
> > @@ -11,7 +11,7 @@ ACPID_LICENSE = GPL-2.0+
> >  ACPID_LICENSE_FILES = COPYING
> >
> >  define ACPID_INSTALL_INIT_SYSTEMD
> > -     $(INSTALL) -D -m 0755 package/acpid/acpid.service \
> > +     $(INSTALL) -D -m 0644 package/acpid/acpid.service \
> >               $(TARGET_DIR)/usr/lib/systemd/system/acpid.service
> >       mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
> >       ln -sf ../../../../usr/lib/systemd/system/acpid.service \
> >


More information about the buildroot mailing list