[Buildroot] [PATCH] package/intel-microcode: don't use install -D -t

Carlos Santos casantos at datacom.com.br
Tue Dec 11 15:35:33 UTC 2018


> From: "Thomas Petazzoni" <thomas.petazzoni at bootlin.com>
> To: "buildroot" <buildroot at buildroot.org>
> Cc: "Carlos Santos" <casantos at datacom.com.br>, "Thomas Petazzoni" <thomas.petazzoni at bootlin.com>, "Maxime Hadjinlian"
> <maxime.hadjinlian at gmail.com>
> Sent: Terça-feira, 11 de dezembro de 2018 13:30:05
> Subject: [PATCH] package/intel-microcode: don't use install -D -t

> Commit 1f0beaf9a8e2b8f0bb6e53694b38d70900b9128f ("intel-microcode:
> bump to version 20180807a") introduced the use of "install -D -t" to
> the intel-microcode package. The intent is that install will create
> the full destination directory, including all components leading to
> it, before copying the files.
> 
> Unfortunately, "install -D -t" is only supported since coreutils since
> v8.23. Several of the build systems we support have older coreutils
> versions, such as Debian 7, which uses coreutils 8.13. Ubuntu 14.04
> also doesn't have a recent enough coreutils.
> 
> So let's create the directory explicitly first, and then use a more
> regular "install -t".
> 
> Fixes:
> 
>  http://autobuild.buildroot.net/results/aa44f9ff90f296f886be6309b3355ed075494fb2/
> 
> Note: the "gzip: stdout: Broken pipe" messages in those failures seem
> unrelated. We have been able to reproduce the installation failure
> without those "Broken pipe" issues, and we have not been able to
> reproduce those "Broken pipe" problems.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> ---
> package/intel-microcode/intel-microcode.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/intel-microcode/intel-microcode.mk
> b/package/intel-microcode/intel-microcode.mk
> index 2113873509..ed4ad628dd 100644
> --- a/package/intel-microcode/intel-microcode.mk
> +++ b/package/intel-microcode/intel-microcode.mk
> @@ -13,7 +13,8 @@ INTEL_MICROCODE_LICENSE_FILES = license
> INTEL_MICROCODE_REDISTRIBUTE = NO
> 
> define INTEL_MICROCODE_INSTALL_TARGET_CMDS
> -	$(INSTALL) -D -m 0644 -t $(TARGET_DIR)/lib/firmware/intel-ucode \
> +	mkdir -p $(TARGET_DIR)/lib/firmware/intel-ucode
> +	$(INSTALL) -m 0644 -t $(TARGET_DIR)/lib/firmware/intel-ucode \
> 		$(@D)/intel-ucode/*
> endef
> 
> --
> 2.19.2

Tested-by: Carlos Santos <casantos at datacom.com.br>

Tested on a DATACOM device with Intel C3000 processor.

-- 
Carlos Santos (Casantos) - DATACOM, P&D


More information about the buildroot mailing list