[Buildroot] [PATCH] package/waf: purge trailig '/' from WAF_SITE

Arnout Vandecappelle arnout at mind.be
Mon Dec 10 20:59:37 UTC 2018



On 10/12/2018 20:45, Thomas Petazzoni wrote:
> Hello,
> 
> On Mon, 10 Dec 2018 16:45:59 -0200, Carlos Santos wrote:
>> <PKG>_SITE cannot have a trailing slash.
>>
>> Signed-off-by: Carlos Santos <casantos at datacom.com.br>
> 
> Odd, why isn't our check in package/pkg-generic.mk for trailing slashes
> triggering on this?
> 
> We have this:
> 
> ifeq ($$(patsubst %/,ERROR,$$($(2)_SITE)),ERROR)
> $$(error $(2)_SITE ($$($(2)_SITE)) cannot have a trailing slash)
> endif

 Because that check is within

ifeq ($$($$($(2)_KCONFIG_VAR)),y)
...
endif

and these packages are host-only packages.

 It has to be within that condition, since the _SITE may be set only or
differently based on kconfig options which are only set when the package is
selected. I tested and it fails for instance on arm-trusted-firmware if that
package is not selected.

 We need Config.in.host :-)

 Regards,
 Arnout



More information about the buildroot mailing list