[Buildroot] [PATCH 1/1] package/weston: bump to version 5.0.0

Baruch Siach baruch at tkos.co.il
Mon Dec 10 11:55:39 UTC 2018


Hi James,

James Hilliard writes:
> The patch I removed was just a backport of this
> https://github.com/wayland-project/weston/commit/029583e56e6eaad4139e39b4cf908158ab8cc91a
> which is now included in 5.0.0.

This is great (and should appear in the commit log). But besides that
there are these lines in weston.mk:

# 0002-rdp-compositor-fix-compilation-against-FreeRDP-2.0.0.patch
WESTON_AUTORECONF = YES

The comment is clearly wrong once you remove the patch. Moreover,
autoreconf itself might not be needed anymore. In that case you should
remove it.

baruch

> On Mon, Dec 10, 2018 at 4:29 AM Baruch Siach <baruch at tkos.co.il> wrote:
>> james.hilliard1 at gmail.com writes:
>> > From: James Hilliard <james.hilliard1 at gmail.com>
>> >
>> > Signed-off-by: James Hilliard <james.hilliard1 at gmail.com>
>> > ---
>> >  ...tor-fix-compilation-against-FreeRDP-2.0.0.patch | 181 ---------------------
>> >  package/weston/weston.hash                         |  10 +-
>> >  package/weston/weston.mk                           |   2 +-
>> >  3 files changed, 6 insertions(+), 187 deletions(-)
>> >  delete mode 100644 package/weston/0002-rdp-compositor-fix-compilation-against-FreeRDP-2.0.0.patch
>>
>> As you remove the configure.ac patch, is autoreconf still needed? If it
>> is, please update the autoreconf comment.

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -


More information about the buildroot mailing list