[Buildroot] [PATCH next v6 07/10] core: implement per-package SDK and target
dev at andin.de
Thu Dec 6 13:31:34 UTC 2018
Am 06.12.18 um 11:58 schrieb Thomas Petazzoni:
> Hello Andreas,
> On Thu, 6 Dec 2018 11:42:37 +0100, Andreas Naumann wrote:
>>> Nope, this is expected. During the build output/host/lib doesn't exist,
>> of course
>>> it's only populated at the very end of the build in host-finalize. So
>>> indeed the RPATH of binaries point to various per-package host/lib
>>> folders. This is totally expected.
>> Hmm, at this stage the host-finalize step was already run, so now
>> output/host does exist.
> Yes, but the RPATH of host binaries are not fixed up in host-finalize.
> They are fixed up as part of prepare-sdk:
> prepare-sdk: world
> @$(call MESSAGE,"Rendering the SDK relocatable")
> $(TOPDIR)/support/scripts/fix-rpath host
> $(TOPDIR)/support/scripts/fix-rpath staging
> so it is totally expected that at the end of the build the host
> binaries carry those RPATH pointing to per-package host/lib folders.
> And it is not a problem: those folders exist, they contain the right
> libraries, so it's perfectly fine.
>>>> After 'make prepare-sdk'
>>>> $ readelf -d output/host/sbin/mkfs.ext3
>>>> 0x000000000000001d (RUNPATH) Bibliothek runpath: 
>>> This is obviously not good :-)
>>> Thanks for reporting that, I'll have a look. I guess it's simply the
>>> fixup of RPATH from absolute to relative that goes wrong.
>> Would moving the fix-rpath step from prepare-sdk to host-finalize hurt?
> It would not fix your problem: this fix-rpath step is currently broken
> as it doesn't understand how to rewrite those RPATHs that point to
> per-package host/lib.
Yes, I didnt mean this as remedy, but as addon to a fix exactly as you
> So there are really two separate things:
> - Fixing the fix-rpath logic so that it works with per-package
> host/lib RPATHs. This is mandatory. After doing that, at the end of
> the build, the RPATH would still point to per-package host/lib, but
> after prepare-sdk you will have again the correct relative RPATH you
> used to have before the per-package stuff.
> - Moving fix-rpath at the end of the build so that instead of those
> weird per-package host/lib RPATH, you have nice relative RPATHs,
> without the need to run prepare-sdk. This is not mandatory at all,
> and would be just for convenience/beauty.
One additional thought: Regardless of when fix-rpath runs, once it ran,
the content of host, and because of all the hard-links, per-package are
changed. I understand that in theory this should have no impact (to
further compiling other packages for example). But in case of
bugs/corner-cases whatever, it might be more difficult to debug the two
different states. So I guess this is more an argument against earlier
execution of fix-rpath.
> Best regards,
More information about the buildroot