[Buildroot] [PATCH v4 3/3] fs/common.mk: make sure that static devices from packages are created

Arnout Vandecappelle arnout at mind.be
Wed Dec 5 09:18:44 UTC 2018



On 05/12/2018 08:53, Thomas Petazzoni wrote:
> Hello,
> 
> On Tue, 4 Dec 2018 22:05:19 +0100, Arnout Vandecappelle wrote:
> 
>>> diff --git a/fs/common.mk b/fs/common.mk
>>> index 077ce8903e..a560417c6c 100644
>>> --- a/fs/common.mk
>>> +++ b/fs/common.mk
>>> @@ -61,10 +61,10 @@ endif
>>>  	$(call PRINTF,$(PACKAGES_PERMISSIONS_TABLE)) > $(ROOTFS_FULL_DEVICES_TABLE)
>>>  ifneq ($(ROOTFS_DEVICE_TABLES),)
>>>  	cat $(ROOTFS_DEVICE_TABLES) >> $(ROOTFS_FULL_DEVICES_TABLE)
>>> +endif
>>>  ifeq ($(BR2_ROOTFS_DEVICE_CREATION_STATIC),y)
>>>  	$(call PRINTF,$(PACKAGES_DEVICES_TABLE)) >> $(ROOTFS_FULL_DEVICES_TABLE)
>>>  endif  
>>
>>  This is still conflicting with the purpose of patch 2/3: the package device
>> tables are still overriding the user-specified global device table.
> 
> Fair point. Should we do:
> 
> 	$(call PRINTF,$(PACKAGES_PERMISSIONS_TABLE)) > $(ROOTFS_FULL_DEVICES_TABLE)
> ifeq ($(BR2_ROOTFS_DEVICE_CREATION_STATIC),y)
> 	$(call PRINTF,$(PACKAGES_DEVICES_TABLE)) >> $(ROOTFS_FULL_DEVICES_TABLE)
> endif
> ifneq ($(ROOTFS_DEVICE_TABLES),)
> 	cat $(ROOTFS_DEVICE_TABLES) >> $(ROOTFS_FULL_DEVICES_TABLE)
> endif
> 
> instead ?

 Yep, that's what I meant. I guess.

 Regards,
 Arnout



More information about the buildroot mailing list