[Buildroot] [PATCH 1/1] libbsd: fix display of comment
thomas.petazzoni at bootlin.com
Mon Dec 3 08:14:35 UTC 2018
On Sun, 2 Dec 2018 11:25:51 +0100, Fabrice Fontaine wrote:
> Commit e13855c48f21eaee07a81f8b02678839be274a45 wrongly added
> depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
> to display the comment "libbsd needs a toolchain w/ threads, wchar"
> Set the correct dependency:
> depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
Instead of this (and the related minizip change), what about moving the:
depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
to BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS ?
Since we don't display a comment about it, it is effectively treated
like an architecture dependency, and it kind of is, since anyway the
only C library that supports noMMU systems is uClibc (yes, musl
supports noMMU on SH2, but we don't support that in Buildroot).
Having this dependency directly in BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
avoid the need to replicate it to all reverse dependencies of libbsd
(and therefore the reverse dependencies should be changed as well).
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
More information about the buildroot