[Buildroot] [PATCH 1/1] minizip: fix display of comment

Fabrice Fontaine fontaine.fabrice at gmail.com
Sun Dec 2 11:23:14 UTC 2018


Dear Baruch,

Le dim. 2 déc. 2018 à 11:32, Baruch Siach <baruch at tkos.co.il> a écrit :
>
> Hi Fabrice,
>
> Fabrice Fontaine writes:
> > Commit e13855c48f21eaee07a81f8b02678839be274a45 wrongly added
> > depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
> > to display the comment "minizip needs a toolchain w/ threads, wchar"
>
> Why is it wrong? This dependency is meant to hide the comment in the
> !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU) case.
It is wrong because, in commit
e13855c48f21eaee07a81f8b02678839be274a45, I added in minizip/Config.in
(and in libbsd/Config.in):
config BR2_PACKAGE_MINIZIP
   depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU) # libbsd
[...]
comment "minizip needs a toolchain w/ threads, wchar"
    depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
    depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR

As a result, the comment is not displayed with an uclibc toolchain
with MMU but without wchar.
So, the user don't know that it has just to select wchar to be able to
select minizip.
>
> > Set the correct dependency:
> > depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> > ---
> >  package/minizip/Config.in | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/minizip/Config.in b/package/minizip/Config.in
> > index 4bc12a0d7e..ff8b5b209a 100644
> > --- a/package/minizip/Config.in
> > +++ b/package/minizip/Config.in
> > @@ -20,5 +20,5 @@ config BR2_PACKAGE_MINIZIP_DEMOS
> >
> >  comment "minizip needs a toolchain w/ threads, wchar"
> >       depends on BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
> > -     depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
> > +     depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
> >       depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
>
> baruch
>
> --
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Best Regards,

Fabrice


More information about the buildroot mailing list