[Buildroot] [PATCH 5/7] support/testing: add test of BR2_CCACHE with an external toolchain

Arnout Vandecappelle arnout at mind.be
Mon Jul 10 20:10:13 UTC 2017



On 10-07-17 18:01, Thomas Petazzoni wrote:
> Hello,
> 
> On Mon, 10 Jul 2017 01:21:21 +0200, Arnout Vandecappelle
> (Essensium/Mind) wrote:
>> We piggy-back on an existing test.
>>
>> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
>> ---
>>  support/testing/tests/toolchain/test_external.py | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/support/testing/tests/toolchain/test_external.py b/support/testing/tests/toolchain/test_external.py
>> index afb4bb0b50..c315ef8055 100644
>> --- a/support/testing/tests/toolchain/test_external.py
>> +++ b/support/testing/tests/toolchain/test_external.py
>> @@ -207,9 +207,13 @@ BR2_TOOLCHAIN_EXTERNAL_CXX=y
>>          self.emulator.login()
>>  
>>  class TestExternalToolchainBuildrootuClibc(TestExternalToolchain):
>> +    # On this test we piggy-back a test of BR2_CCACHE in combination
>> +    # with an external toolchain.
> 
> I'm not sure I'm a big fan of "hijacking" an existing test to validate
> ccache. Shouldn't we have a separate test for that, clearly identified
> as being ccache related?
> 
> Could be a test that inherits from this one, and simply adds more
> options. But at least in case of failure it will be clearly identified
> as a CCache related test in the Gitlab CI results.

 I didn't want to duplicate stuff, that's why. Inheriting is a great idea.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF


More information about the buildroot mailing list