[Buildroot] [PATCH 1/1] capnproto: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Fri Jul 7 07:44:43 UTC 2017


Hello,

On Fri, 07 Jul 2017 08:58:08 +0200, Koen Martens wrote:

> >Since upstream uses Git, we prefer to have a Git-formatted patch, i.e
> >generated with "git format-patch -N". It should also have a proper
> >commit title, i.e a single line at the beginning that summarizes the
> >commit, separated from the rest of the commit log by one empty line.  
> 
> Sure, except the published tarball is from a subdirectory of the
> upstream git repo. So creating a git patch with format-patch results
> in a patch that needs 'patch -p2' to apply in buildroot. I understand
> this is impossible. What do you prefer i do? Manually modify the
> patch to remove the subdir that should be stripped?

Gah, OK. Then perhaps a quick comment in the patch description would be
nice, like:

[Patch cannot be generated with git format-patch, as the upstream Git
repository directory layout doesn't match the tarball directory layout]

> >> +CAPNPROTO_DEPENDENCIES = host-capnproto  
> >
> >Could you give some details as to why the host capnproto is necessary
> >to build the target capnproto ?  
> 
> Capnproto provides a compiler to compile capnproto message
> definitions to c++ code. The library uses capnproto messages itself,
> and thus needs the capnproto compiler to compile. This obviously must
> be the host capnproto compiler, because the target compiler will not
> run on the compiling host.
> 
> Is that sufficient detail, or do you want this in the package files
> somewhere? If so, where?

A quick comment above the dependency would be nice, like:

# Needs the capnproto compiler on the host to generate C++ code from
# message definitions

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list