[Buildroot] [git commit] support/check-package: don't check filenames of hashes

Peter Korsgaard peter at korsgaard.com
Mon Jul 3 15:33:22 UTC 2017

commit: https://git.buildroot.net/buildroot/commit/?id=efb61ae07bfe21bda5b323364a2b38ece01ba40a
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Currently, we check that the filenames in hash lists do not contain
a slash '/' character, because all we are checking so far are the
downloaded archives, and we explicitly need the filename to not contain
a directory component at all.

However, we're soon to also check the hashes of the license files in
packages sources, and those license files may be at any arbitrary
directory-depth in the packages source tree.

[Peter: Remove reference to files with same basename]
Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
Cc: Luca Ceresoli <luca at lucaceresoli.net>
Cc: Peter Korsgaard <peter at korsgaard.com>
Cc: Rahul Bedarkar <rahulbedarkar89 at gmail.com>
Cc: Ricardo Martincoski <ricardo.martincoski at gmail.com>
Acked-by: Ricardo Martincoski <ricardo.martincoski at gmail.com>
Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
 utils/checkpackagelib/lib_hash.py | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/utils/checkpackagelib/lib_hash.py b/utils/checkpackagelib/lib_hash.py
index 10b2748..c4d055e 100644
--- a/utils/checkpackagelib/lib_hash.py
+++ b/utils/checkpackagelib/lib_hash.py
@@ -17,22 +17,6 @@ def _empty_line_or_comment(text):
     return text.strip() == "" or text.startswith("#")
-class HashFilename(_CheckFunction):
-    def check_line(self, lineno, text):
-        if _empty_line_or_comment(text):
-            return
-        fields = text.split()
-        if len(fields) < 3:
-            return
-        if '/' in fields[2]:
-            return ["{}:{}: use filename without directory component"
-                    " ({}#adding-packages-hash)"
-                    .format(self.filename, lineno, self.url_to_manual),
-                    text]
 class HashNumberOfFields(_CheckFunction):
     def check_line(self, lineno, text):
         if _empty_line_or_comment(text):

More information about the buildroot mailing list