[Buildroot] [PATCH 1/4] configs/altera_sockit: bump kernel to 4.7 and u-boot to v2016.11-rc3

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Fri Jan 20 03:15:13 UTC 2017


Hello,

On Thu, 19 Jan 2017 10:32:10 -0500, Lucas Bajolet wrote:

>  BR2_TARGET_UBOOT=y
> -BR2_TARGET_UBOOT_BOARDNAME="socfpga_cyclone5"
> +BR2_TARGET_UBOOT_BOARDNAME="socfpga_sockit"
>  BR2_TARGET_UBOOT_CUSTOM_GIT=y
> -BR2_TARGET_UBOOT_CUSTOM_REPO_URL="http://git.rocketboards.org/u-boot-socfpga.git"
> -BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="rel_acds13.0sp1"
>  BR2_TARGET_UBOOT_PATCH="board/altera/sockit"
> +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://github.com/altera-opensource/u-boot-socfpga"
> +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="v2016.11-rc3"

Why do you bump to a -rc version rather than a final stable version?

Also, you only remove the existing U-Boot patch in PATCH 2/4. Which
means if I apply only PATCH 1/4, the build is broken.

Patch series should be bisectable: applying PATCH 1/4 only should work,
applying PATCH 1/4 and 2/4 only should work, applying PATCH 1/4, 2/4
and 3/4 only should work.

Could you rework your series with this in mind?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list