[Buildroot] [PATCH 07/24 v2] system: provide no default for custom skeleton path

Arnout Vandecappelle arnout at mind.be
Mon Jul 4 07:30:55 UTC 2016


On 03-07-16 10:42, Romain Naour wrote:
> Yann,
> 
> Le 22/06/2016 à 21:07, Yann E. MORIN a écrit :
>> Being custom means that our default one is not suitable to start with.
>>
>> So there is no reson to offer it as the default path.
>>
>> Add a separating empty line, for good measure, too.
>>
>> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
>> ---
>>  system/Config.in | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/system/Config.in b/system/Config.in
>> index 4f9f270..04b886b 100644
>> --- a/system/Config.in
>> +++ b/system/Config.in
>> @@ -179,9 +179,9 @@ config BR2_ROOTFS_SKELETON_CUSTOM
>>  endchoice
>>  
>>  if BR2_ROOTFS_SKELETON_CUSTOM
>> +
>>  config BR2_ROOTFS_SKELETON_CUSTOM_PATH
>>  	string "custom target skeleton path"
>> -	default "system/skeleton"
> 
> Then, I think we should add a check in skeleton.mk if
> BR2_ROOTFS_SKELETON_CUSTOM_PATH is not empty and print an explicit error message.

 +1 to that. I checked, we don't have it at the moment.

 Regards,
 Arnout

> 
> Best regards,
> Romain
> 
> 
>>  	help
>>  	  Path to custom target skeleton.
>>  
>>
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF



More information about the buildroot mailing list