[Buildroot] [PATCH v3] asciidoc: use absolute path for resources

Peter Korsgaard peter at korsgaard.com
Wed Jul 27 19:21:42 UTC 2016


>>>>> "Matt" == Matt Weber <matthew.weber at rockwellcollins.com> writes:

 > From: Atul Singh <atul.singh.mandla at rockwellcollins.com>
 > One of the "features" of a2x is that the '-r|--resource' flag imports
 > resources relative to the [SOURCE_FILE], not the CWD. The current
 > implementation tries to import resources from the destination dir $(@D),
 > which works fine for out-of-tree builds because $(@D) is an absolute
 > path, however in-tree builds treat $(@D) as a relative path, which breaks
 > because a2x treats $(@D) relative to SOURCE_FILE.

 > Use the make command $(abspath names...) to convert the dest dir to an
 > absolute path before passing it as a resource.

 > Reviewed-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>

 > Signed-off-by: Brandon Maier <brandon.maier at rockwellcollins.com>
 > Signed-off-by: Atul Singh Mandla <atul.singh.mandla at rockwellcollins.com>
 > Signed-off-by: Matt Weber <matthew.weber at rockwellcollins.com>

Committed, thanks.

Like Yann, I also cannot reproduce any errors without it. How do you
trigger it?

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list