[Buildroot] [PATCH 2/3] package/runc: fix shared only build when libseccomp is enabled.
romain.naour at gmail.com
Wed Jul 13 21:18:34 UTC 2016
Hi Christian, Thomas,
Le 08/07/2016 à 21:55, Christian Stewart a écrit :
> On Fri, Jul 8, 2016 12:50 PM, Thomas Petazzoni
> thomas.petazzoni at free-electrons.com <mailto:thomas.petazzoni at free-electrons.com>
> OK. Can we remove unconditionally, or should we still keep it for
> BR2_STATIC_LIBS=y builds?
> Perhaps we should pass -extldflags '$(TARGET_LDFLAGS)', since
> TARGET_LDFLAGS will automatically contain -static when
> That should be fine since extldflags is, I believe, only passed to C related
> For the specific case of runc, is “RUNC_GOTAGS = static_build” needed
> when BR2_STATIC_LIBS=y ?
> That go tag is related to linking Go related code… In the runc code with a quick
> grep I see only one inconsequential place it's actually referenced:
> Godeps/_workspace/src/github.com/godbus/dbus/homedir_dynamic.go:// +build
> Godeps/_workspace/src/github.com/godbus/dbus/homedir_static.go:// +build
> And in that code I cannot even see the logic between the differences in the two
> files, as far as I can tell when doing a static build it just looks up the
> current home dir of the user, when doing a dynamic build it does some
> complex /etc/passwd checking or the like. Absolutely nonsensical.
> I'd just leave the static_build tag in there unconditionally, as it seems to
> have little to no effect anyway, and turning it off will actually result in some
> more complex and unnecessary home directory detection code being activated.
Ok, thanks for your explanation.
Actually this patch is a try to fix the libseccomp build issue... I wasn't sure
about using "static_build" only for static builds.
I don't know much the Go build system but it seems possible to link dynamically
with libseccomp.so thanks to cgo being enabled (CGO_ENABLED=1).
Can you test Thomas's proposal (pass -extldflags '$(TARGET_LDFLAGS)') ?
Feel free to respin these patches and continue the work on docker-engine ;)
More information about the buildroot