[Buildroot] [PATCH 01/13] core: do not attempt downloads with no _VERSION set

Peter Korsgaard peter at korsgaard.com
Sun Jul 3 11:12:35 UTC 2016

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

 > From: Alex Suykov <alex.suykov at gmail.com>
 > Currently, when the package defines no _SOURCE and no _VERSION
 > variables, we end up trying to download <PACKAGE>-undefined.tar.gz.

 > This is utterly pointless.

 > Change the logic to not attempt a download when neither _SOURCE
 > nor _VERSION is set:
 >   - do not set an undefined _VERSION to "undefined"
 >   - do not append an empty (or "undefined") version to the package
 >     rawname

 > Consequently, for packages that have no _VERSION, the build
 > directory will be just the package name (which to some may look
 > nicer than the current "package-undefined").

 > Furthermore, the message trace is also a bit leaner (to the same
 > people that find "package" nicer than "package-undefined").

 > Signed-off-by: Alex Suykov <alex.suykov at gmail.com>
 > Tested-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
 > Reviewed-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
 > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>

Committed entire series, thanks.

Bye, Peter Korsgaard

More information about the buildroot mailing list