[Buildroot] [PATCH 07/24 v2] system: provide no default for custom skeleton path

Romain Naour romain.naour at gmail.com
Sun Jul 3 08:42:56 UTC 2016


Yann,

Le 22/06/2016 à 21:07, Yann E. MORIN a écrit :
> Being custom means that our default one is not suitable to start with.
> 
> So there is no reson to offer it as the default path.
> 
> Add a separating empty line, for good measure, too.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> ---
>  system/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/system/Config.in b/system/Config.in
> index 4f9f270..04b886b 100644
> --- a/system/Config.in
> +++ b/system/Config.in
> @@ -179,9 +179,9 @@ config BR2_ROOTFS_SKELETON_CUSTOM
>  endchoice
>  
>  if BR2_ROOTFS_SKELETON_CUSTOM
> +
>  config BR2_ROOTFS_SKELETON_CUSTOM_PATH
>  	string "custom target skeleton path"
> -	default "system/skeleton"

Then, I think we should add a check in skeleton.mk if
BR2_ROOTFS_SKELETON_CUSTOM_PATH is not empty and print an explicit error message.

Best regards,
Romain


>  	help
>  	  Path to custom target skeleton.
>  
> 



More information about the buildroot mailing list