[Buildroot] [PATCH v1 1/1] package/busybox: support spaces in module aliases in mdev

Andy Shevchenko andriy.shevchenko at linux.intel.com
Sat Jul 2 11:43:46 UTC 2016


On Fri, 2016-07-01 at 23:53 +0200, Yann E. MORIN wrote:
> Andy, Thomas, All,
> 
> On 2016-07-01 22:54 +0200, Thomas Petazzoni spake thusly:
> > On Fri,  1 Jul 2016 21:56:19 +0300, Andy Shevchenko wrote:
> > > The new change which enabled automatic module loading on boot does
> > > not handle
> > > the cases when module alias includes spaces. It prevents modules
> > > to be loaded
> > > since script fails:
> > > 
> > >   % find /sys/ -name modalias | xargs sort -u
> > >   sort: /sys/devices/platform/Fixed: No such file or directory
> > > 
> > > First alias in question is "platform:Fixed MDIO bus".
> > > 
> > > Amend the script to support above like cases.
> > > 
> > > Fixes: 07f46c2b6dae ("package/busybox: support automatic module
> > > loading with mdev")
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> > 
> > Thanks for this patch. However, I have one question below.
> > 
> > > -	find /sys/ -name modalias | xargs sort -u | xargs
> > > modprobe -abq
> > > +	find /sys -name modalias -print0 | xargs -0 sort -u |
> > > while read ma; do
> > 
> > Why is /sys/ changed to /sys ?
> > 
> > Is it because of the sort -u that you cannot do another xargs -0 for
> > the modprobe (which would look nice that the "while read ... done"
> > loop) ?
> 
> sort has a -z option to output with zero-teminated lines instead of
> \n.
> So we could do (almost untested):
> 
>     find /sys/ -name modalias -print0 |xargs -0 sort -u -z |xargs -0
> modprobe -abq

Rough test shows it's working. I will prepare an updated version of the
patch, test it and then send to the list soon.

> 
> Note: the -z option to sort in Busybox depends on SORT_BIG, which is
> enabled in out busybox bundled configuration, so we can use it.
> 
> Regards,
> Yann E. MORIN.
> 

-- 

Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy


More information about the buildroot mailing list