[Buildroot] [PATCH 1/1] Added OK/FAIL output to SNMP init script.
universeii at gmx.de
Thu Feb 25 20:02:07 UTC 2016
thanks for the feedback. I will prepare several patches including
smaller changes and re-submit them.
Am 25.02.2016 um 10:46 schrieb Thomas Petazzoni:
> Dear Andreas Ehmanns,
> On Wed, 24 Feb 2016 18:31:21 +0100, Andreas Ehmanns wrote:
>> Signed-off-by: Andreas Ehmanns <universeII at gmx.de>
>> package/netsnmp/S59snmpd | 98 +++++++++++++++++++++++++++---------------------
>> 1 file changed, 56 insertions(+), 42 deletions(-)
> While your patch looks OK, it is doing *much* more than "adding
> OK/FAIL" as your commit title indicates.
> Ideally, you should separate your changes into multiple patches to make
> it easier to review the changes (like one patch to change to use
> functions, one patch to add OK/FAIL, one patch to remove set -e, etc.).
> Or at least, write a commit log that details all the changes that are
> being done.
> Thanks a lot!
More information about the buildroot