[Buildroot] [git commit] madplay: fix build on noMMU platforms

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Dec 7 22:24:07 UTC 2016

commit: https://git.buildroot.net/buildroot/commit/?id=cb4a41c62e45c1942a603ec176ba7d6d9ee18b95
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

A recent change in uClibc-ng removed the MADV_* definitions for
madvise(), but kept the madvise() function itself. This defeats the
logic used in madplay: it checks if madvise() is available, and if it
is, uses it and assumes the MADV_* definitions exist.

This inconsistency has been reported to upstream uClibc-ng, but in the
mean time, we can simply tell madplay to not use madvise(), which is
anyway useless on noMMU platforms.



Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
 package/madplay/madplay.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/package/madplay/madplay.mk b/package/madplay/madplay.mk
index 2606ac8..6b13819 100644
--- a/package/madplay/madplay.mk
+++ b/package/madplay/madplay.mk
 MADPLAY_DEPENDENCIES = libmad libid3tag $(if $(BR2_PACKAGE_GETTEXT),gettext)
+# Workaround a bug in uClibc-ng, which exposes madvise() but doesn't
+# provide the corresponding MADV_* definitions. Bug reported at
+# http://mailman.uclibc-ng.org/pipermail/devel/2016-December/001306.html. madvise()
+# is anyway useless on noMMU.
+ifeq ($(BR2_USE_MMU),)
+MADPLAY_CONF_ENV += ac_cv_func_madvise=no
 # Check if ALSA is built, then we should configure after alsa-lib so
 # ./configure can find alsa-lib.

More information about the buildroot mailing list