[Buildroot] [PATCH] bluez5_utils: add autoreconf back

Peter Korsgaard peter at korsgaard.com
Mon Dec 5 22:39:21 UTC 2016

>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:


 >> So, we've got two options here:
 >> 1. Say that having to change the original .mk file of a package in
 >> Buildroot is a fact of life if you add custom patches for this
 >> package.

 >  Actually, for this particular case, it would be sufficient to patch Makefile in
 > addition to Makefile.in. Which is a fact of life I'd say. We also sometimes have
 > to do that when autoreconf doesn't work.

 >> 2. Imagine a mechanism that allows the "external" stuff to set
 >> autoreconf on a per-package basis.

 >  Eek please no.

 >  One thing I can imagine is that the expansion of the package infras is done
 > later (after inclusion of external.mk). The first pass would just set variables,
 > not define rules and definitely not use any ifdefs. The rules etc. would then
 > have to avoid using $(1) $(2) etc, and just rely on $($(PKG)_NAME) and friends.

Lets not complicate things too much. Just patching Makefile as well
and/or modifying the package is imho good enough.

Bye, Peter Korsgaard

More information about the buildroot mailing list