[Buildroot] [PATCH 3/3] ljsyscall: refactor with BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Fri Mar 20 22:43:06 UTC 2015

Dear Francois Perrad,

On Tue, 17 Mar 2015 21:04:49 +0100, Francois Perrad wrote:

> diff --git a/package/ljsyscall/Config.in b/package/ljsyscall/Config.in
> index dcbd521..b9ff04d 100644
> --- a/package/ljsyscall/Config.in
> +++ b/package/ljsyscall/Config.in
> @@ -3,12 +3,12 @@ config BR2_PACKAGE_LJSYSCALL
>  	# ljsyscall is specifically for LuaJIT, not Lua.
>  	depends on BR2_PACKAGE_LUAJIT
>  	# ljsyscall is only available for some target architectures
> -	depends on BR2_i386 || BR2_x86_64 || BR2_powerpc || BR2_arm || BR2_armeb

Since you say yourself in the discussion that the set of architectures
supported by ljsyscall is the same as the set of architectures
supported by LuaJIT, then this 'depends on
BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS' is not needed, because this package
already 'depends on BR2_PACKAGE_LUAJIT'.

So if BR2_PACKAGE_LUAJIT has been enabled,
BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS must be true. So adding this
dependency does not make sense.

Can you rework the ljlinenoise and ljsyscall patches to remove this
architecture dependency?


Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering

More information about the buildroot mailing list