[Buildroot] Worried about patches not being merged?
joerg.krause at embedded.rocks
Fri Mar 20 15:33:16 UTC 2015
On Do, 2015-03-19 at 09:20 +0100, Thomas Petazzoni wrote:
> On Wed, 18 Mar 2015 21:01:06 +0100, Jörg Krause wrote:
> > Are there any guidelines for reviewing?
> Not really. Just pick patches touching things you are a bit comfortable
> with, give them some testing, and do some comments if needed. On the
> other hand, if you think the patch is fine, simply reply with a
> Reviewed-by tag.
To be honest, I'm only looking for packages I'm currently using or which
seems to be interesting to me. I must confess I don't have the time to
review/test patches I don't care about or which looks to complex.
Following the mailing list for some months now I noticed that there is a
team of five to ten main contributers which do the most reviews and
tests. Maybe a section in the documentation
I think patches should be classified as you mentioned in another mail. I
like the idea have having tags like "infrastructure", "new package",
"version bump", ..., to get a quick overview.
> Of course, reviewing simple package bumps or hash file additions is not
> very useful, since I tend to apply such patches quickly: there is not
> much potential trouble with such patches.
> > It's a pitty that GSoC did not accepted Buildroot this year. The
> > testing scripts would be a nice feature.
> Yes, it is a pitty, but hopefully someone will pick up the task and
> work on improving our QA tooling :)
More information about the buildroot