[Buildroot] [PATCH v1] postgresql: fix xtensa pthread linking flags
jcmvbkbc at gmail.com
Thu Mar 19 23:30:39 UTC 2015
On Fri, Mar 20, 2015 at 2:17 AM, Peter Seiderer <ps.report at gmx.net> wrote:
> Hello Max,
> On Fri, Mar 20, 2015 at 01:50:22AM +0300, Max Filippov wrote:
>> On Fri, Mar 20, 2015 at 12:42 AM, Max Filippov <jcmvbkbc at gmail.com> wrote:
>> > On Fri, Mar 20, 2015 at 12:29 AM, Peter Seiderer <ps.report at gmx.net> wrote:
>> >> Caused by pthread flags autodetection failure while configure (from config.log):
>> >> configure:12436: checking whether pthreads work with -pthread
>> >> configure:12521: host/usr/bin/xtensa-linux-gcc -o conftest -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -mlongcalls -mtext-section-literals -Os -pthread -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE conftest.c -lssl -lcrypto -lz -lrt -lcrypt -ldl -lm >&5
>> >> conftest.c: In function 'main':
>> >> conftest.c:140:27: warning: 'th' is used uninitialized in this function [-Wuninitialized]
>> >> pthread_t th; pthread_join(th, 0);
>> >> ^
>> >> host/usr/xtensa-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.so: warning: gethostbyname is obsolescent, use getnameinfo() instead.
>> >> configure:12521: $? = 0
>> > But the test has actually succeeded according to the exit code.
>> > Maybe we'd better fix configure?
>> I see the issue comes from config/acx_pthread.m4:146
>> # Check both linking and compiling, because they might tolerate
>> different options.
>> if test "`(eval $ac_link 2>&1 1>&5)`" = "" && test "`(eval
>> $ac_compile 2>&1 1>&5)`" = ""; then
>> where non-empty stdout + stderr output of the linker and compiler
>> fail the test. And the linker gives the following warning during that test:
>> libcrypto.so: warning: gethostbyname is obsolescent, use
>> getnameinfo() instead.' = ''
> Thanks for taking a look at it, you are rigth with your problem description (I
> suspected the warning output too), any suggestions how to fix it?
> Or file a bugreport upstream?
The attached patch fixes it for me, but I'm curious why it was
done that way at all. Looking at postgres repository doesn't
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2493 bytes
Desc: not available
More information about the buildroot