[Buildroot] [PATCH v2 2/3] package/mesa3d: bump version to 10.5.1
thomas.petazzoni at free-electrons.com
Tue Mar 17 22:30:27 UTC 2015
Dear Bernd Kuhls,
On Sun, 15 Mar 2015 17:10:01 +0100, Bernd Kuhls wrote:
> Dropped several dependencies because the "distribution tarball has been renamed
> and now contains all the generated sources."
> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>
> v2: updated hash (Baruch), added note about dependency changes (Thomas)
Thanks for the additional explanation, makes a lot more sense now. I've
applied your patch. I however have a comment:
> ++#ifdef __UCLIBC__
> ++float fmaxf(float a, float b)
This is really a crappy solution. I know we use it in various places,
but it simply does not work properly: if a new version of uClibc is
released with an implementation of fmaxf(), then __UCLIBC__ will still
be true, but we'll have a duplicated implementation of fmaxf().
is an excellent demonstration of why using __UCLIBC__ is bad. This
build failure is caused by the patch
package/freerdp/0001-add-support-for-uclibc.patch, wihch just like
yours adds replacement function if __UCLIBC__ is defined.
Now, enters uClibc-ng, which does implement eventfd_read() and
eventfd_write(), and bang, it fails.
Solution: use a proper autoconf test to see if fmax() is available or
not, or provide an alternate implementation only if it's not already
Since we're doing this __UCLIBC__ trick in lots of places, I've
nonetheless applied your patch, but it'd be good to use proper
solutions in the future.
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
More information about the buildroot