[Buildroot] [PATCH v2] package/sysdig: New package

Baruch Siach baruch at tkos.co.il
Tue Mar 17 11:48:16 UTC 2015


Hi Angelo,

On Tue, Mar 17, 2015 at 12:31:48PM +0100, Angelo Compagnucci wrote:
> 2015-03-17 12:23 GMT+01:00 Baruch Siach <baruch at tkos.co.il>:
> > On Tue, Mar 17, 2015 at 11:56:48AM +0100, Angelo Compagnucci wrote:
> >> +     depends on BR2_LINUX_KERNEL
> >> +     help
> >> +       Sysdig is open source, system-level exploration:
> >> +       capture system state and activity from a running Linux instance,
> >> +       then save, filter and analyze.
> >> +       Think of it as strace + tcpdump + lsof + awesome sauce.
> >> +       With a little Lua cherry on top.
> >> +
> >> +       http://sysdig.org
> >
> > A dependencies comment is still missing here
> > (http://nightly.buildroot.org/manual.html#_dependencies_on_a_linux_kernel_built_by_buildroot).
> 
> The comment is there:
> 
> @@ -0,0 +1,17 @@
> +comment "sysdig needs a Linux kernel to be built"
> + depends on !BR2_LINUX_KERNEL

You are right, I missed that. It's just that I'm used to see these comments 
below the main 'config' section. Putting the comment above is also fine, 
though. Don't forget to update this comment when adding indirect dependencies.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -



More information about the buildroot mailing list