[Buildroot] [PATCH 2/2] samba4: bump to version 4.2.0

Peter Korsgaard peter at korsgaard.com
Tue Mar 10 21:35:46 UTC 2015


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

 > Dear Gustavo Zacarias,
 > On Fri, 06 Mar 2015 06:04:03 -0300, Gustavo Zacarias wrote:

 >> Well,  i've done it several times in the past, just search for "While at
 >> it" and "Also" in the commit logs - in fact it was you who committed
 >> them in many cases (and not only mine).
 >> Does this mean that i should separate bumps from adding hash files
 >> and/or renaming patches?

 > There is obviously a line to draw between things that we can do in the
 > same commit, and things that we should not. I believe adding a hash
 > file together with a bump is OK since anyway doing the bump would
 > change the hash file.

Exactly, the changes logically belong together and are easy/fast to
review.

A version bump + whitespace changes leading to a diffstat like this:

 package/samba4/samba4.mk                           | 100 +++++++------

Is certainly less so. If it was purely a white space change it would be
trivial to verify with git diff -w, E.G.:

git show -w 7152a50588

 >> Because the workload and noise committing will go up higher if that's
 >> the choice.

We already have 400+ commits/month, so 1 extra commit imho doesn't
hurt. It is true that it involves a bit more time on the contributor,
but is saves time for the maintainer (E.G. the version bumps, especially
yours are normally nobrainers to apply), and the limiting factor these
days seems to be maintainer/review cycles.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list