[Buildroot] [PATCH 2/2] samba4: bump to version 4.2.0

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Fri Mar 6 09:40:10 UTC 2015


Dear Gustavo Zacarias,

On Fri, 06 Mar 2015 06:34:59 -0300, Gustavo Zacarias wrote:

> > I'd say readability. Renaming patches is clearly separated from .mk
> > changes. In the case of your Samba 4.2 bump, the changes within the .mk
> > file are mixed between bump-related changes, and indentation-related
> > changes, and this is what bothers me.
> 
> It doesn't break any bisectability so what's the problem, you don't like
> a patch that changes too many things at once?

Exactly. I'm surprised you even ask, separate logical changes is just
the 101 of open-source contribution in many projects. See
http://lxr.free-electrons.com/source/Documentation/SubmittingPatches#L74
for example.

> Sorry to rehash an old thread but this kind of things don't motivate me
> at all.

I don't quite understand your feeling here. What I'm asking you to do
is something we ask to *all* contributors, including newcomers who have
never contributed a single patch to Buildroot. Why would we have more
relaxed/special rules for long-term contributors like you ?

If I was annoying you with something unusual, which I never bother
other people with, I would understand. But here I'm just asking a very
basic thing, which I also ask to every other contributor.

> One thing is when you say "typo" which well, yes, it's a typo and it's
> fine to correct it.

Sorry I did not understand this part.

Anyway, I'll take care of doing the split of the Samba 4.2 patch and
I'll apply. I would have expected a bit more help and understanding from
a long term contributor such as you.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list