[Buildroot] [PATCH 2/2] samba4: bump to version 4.2.0

Gustavo Zacarias gustavo at zacarias.com.ar
Fri Mar 6 09:34:59 UTC 2015

On 03/06/2015 06:26 AM, Thomas Petazzoni wrote:

>> Because the workload and noise committing will go up higher if that's
>> the choice.
>> And how does a package style fix differ from renaming patches that's
>> another style fix?
> I'd say readability. Renaming patches is clearly separated from .mk
> changes. In the case of your Samba 4.2 bump, the changes within the .mk
> file are mixed between bump-related changes, and indentation-related
> changes, and this is what bothers me.

It doesn't break any bisectability so what's the problem, you don't like
a patch that changes too many things at once?
Sorry to rehash an old thread but this kind of things don't motivate me
at all.
One thing is when you say "typo" which well, yes, it's a typo and it's
fine to correct it.
But this is just personal preference.

More information about the buildroot mailing list