[Buildroot] [PATCH 2/2] samba4: bump to version 4.2.0
thomas.petazzoni at free-electrons.com
Fri Mar 6 08:40:08 UTC 2015
Dear Gustavo Zacarias,
On Thu, 05 Mar 2015 21:11:24 -0300, Gustavo Zacarias wrote:
> > This cleanup of the indentation is definitely good, but has nothing to
> > do with the bump to 4.2.0. It should be part of a separate patch.
> Well, it's pointless IMHO to split it, since some options changed and
> it's a major bump, does it really make sense?
> I won't make a badly-indented 4.2.x package file to fix it later, it
> would be pointless. It'll give me one more commit that doesn't do
> anything useful.
> And "fixing" 4.1.x just to just stomp on it later with the bump would
> make no sense either, same case, many changes.
I'm sorry, but I don't buy this. Separating logical changes is
something we ask to all contributors. And the specific chunk I pointed
at does not change at *all* when doing the 4.1 -> 4.2 bump. And even if
some parts of it are changed by the 4.1 -> 4.2 bump, that's OK.
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
More information about the buildroot