[Buildroot] [PATCH v3 2/2] logrotate: use pkg-config for the opt library

Fabio Porcedda fabio.porcedda at gmail.com
Wed Mar 4 23:38:25 UTC 2015


On Wed, Mar 4, 2015 at 11:29 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Fabio Porcedda,
>
> In the title: s/opt/popt/
>
> On Sun,  1 Mar 2015 22:06:53 +0100, Fabio Porcedda wrote:
>> Without using the pkg-config the dependencies are not included for a
>> static linking so it fails to build.
>> These failures are fixed by linking the libintl library that is a
>> dependency of the opt library.
>
> s/opt/popt/
>
> I've fixed and committed. Though I have one concern below.
>
>
>> +     $(MAKE) CC="$(TARGET_CC) $(TARGET_CFLAGS)" LDFLAGS="$(LDFLAGS)" \
>> +             LOADLIBES="$(shell $(PKG_CONFIG_HOST_BINARY) --libs popt)" \
>
> It's not currently supported in Buildroot, but LOADLIBES is extended by
> the logrotate Makefile with -lacl or -lselinux when WITH_ACL or
> WITH_SELINUX are used. I'm not sure this will play well with your
> proposed solution.

Thanks for noticing it.
I didn't know that a variable forced from the command line cannot be extended.
Now I'm aware of it.

> But ok, this can be handled when/if someone adds ACL and/or SELinux
> support to logrotate.

Good idea.

Thanks
-- 
Fabio Porcedda



More information about the buildroot mailing list