[Buildroot] [PATCH 1/1] Fix barebox compilation issue with 64bit kernel

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Mar 3 13:31:25 UTC 2015


Dear Lahoudere Fabien,

On Tue,  3 Mar 2015 13:27:53 +0100, Lahoudere Fabien wrote:
> Signed-off-by: Lahoudere Fabien <fabienlahoudere.pro at gmail.com>

This should normally be:

	Signed-off-by: <first name> <last name> <email>

> ---
>  boot/barebox/barebox.mk | 2 ++
>  1 file changed, 2 insertions(+)

This looks good but the commit log could be improved:

	barebox: fix compilation on x86-64 architecture

	Barebox uses KERNEL_ARCH to derive BAREBOX_ARCH, but doesn't
	currently handle the case of the x86-64 architecture. In this
	case KERNEL_ARCH is x86_64, but BAREBOX_ARCH should be x86
	nonetheless.

The commit title should almost always look like:

	<pkg>: <description>

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list