[Buildroot] [PATCH v9] package/sysdig: New package

Ryan Barnett ryan.barnett at rockwellcollins.com
Fri Mar 27 00:46:51 UTC 2015


On Thu, Mar 26, 2015 at 3:37 PM, Angelo Compagnucci
<angelo.compagnucci at gmail.com> wrote:
> Dear Ryan Barnett,
>
> Are you sure? IMO, If the patch changes it should be reviewed again.

You do bring up a good point. However, I was basing this on what Yann
did with his hash improvement series:

http://patchwork.ozlabs.org/patch/453147/

> Good catch, but the message should be viewed only on supported arhcs,
> so it should be:
>
>  comment "sysdig needs a toolchain w/ C++ and a Linux kernel to be built"
>          depends on !BR2_LINUX_KERNEL || !BR2_INSTALL_LIBSTDCPP
>          depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS

Yes I agree with this.

Thanks,
-Ryan

-- 
Ryan Barnett / Sr Software Engineer
Airborne Information Systems / Security Systems and Software
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
ryan.barnett at rockwellcollins.com
www.rockwellcollins.com


More information about the buildroot mailing list