[Buildroot] [PATCH v2 05/15] toolchain: remove LARGEFILE selects

Yann E. MORIN yann.morin.1998 at free.fr
Sat Mar 21 11:32:03 UTC 2015


Gustavo, All,

On 2015-03-17 13:48 -0300, Gustavo Zacarias spake thusly:
> There's no need for toolchains or the user to declare largefile support
> since it's now mandatory.
> 
> Signed-off-by: Gustavo Zacarias <gustavo at zacarias.com.ar>
> ---
>  toolchain/Config.in                    |  2 --
>  toolchain/toolchain-external/Config.in | 14 --------------

You forgot to remove the 'select' from uClibc.

It's done in a future patch, indeed, but I guess it makes sense to
squash it here (just removing the 'select', and having patch 6 gettign
rid of BR2_TOOLCHAIN_BUILDROOT_LARGEFILE).

Regards,
Yann E. MORIN.

>  2 files changed, 16 deletions(-)
> 
> diff --git a/toolchain/Config.in b/toolchain/Config.in
> index b039ee2..291db94 100644
> --- a/toolchain/Config.in
> +++ b/toolchain/Config.in
> @@ -9,7 +9,6 @@ config BR2_TOOLCHAIN
>  # Should be selected for glibc or eglibc
>  config BR2_TOOLCHAIN_USES_GLIBC
>  	bool
> -	select BR2_LARGEFILE
>  	select BR2_INET_IPV6
>  	select BR2_USE_WCHAR
>  	select BR2_ENABLE_LOCALE
> @@ -24,7 +23,6 @@ config BR2_TOOLCHAIN_USES_UCLIBC
>  
>  config BR2_TOOLCHAIN_USES_MUSL
>  	bool
> -	select BR2_LARGEFILE
>  	select BR2_INET_IPV6
>  	select BR2_USE_WCHAR
>  	select BR2_ENABLE_LOCALE
> diff --git a/toolchain/toolchain-external/Config.in b/toolchain/toolchain-external/Config.in
> index 8b0f09b..3b7f40b 100644
> --- a/toolchain/toolchain-external/Config.in
> +++ b/toolchain/toolchain-external/Config.in
> @@ -635,7 +635,6 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH2A_201103
>  	depends on BR2_sh2a
>  	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>  	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
> -	select BR2_LARGEFILE
>  	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
>  	select BR2_USE_WCHAR
>  	select BR2_TOOLCHAIN_HAS_THREADS
> @@ -655,7 +654,6 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH2A_201009
>  	depends on BR2_sh2a
>  	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>  	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
> -	select BR2_LARGEFILE
>  	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
>  	select BR2_USE_WCHAR
>  	select BR2_TOOLCHAIN_HAS_THREADS
> @@ -782,7 +780,6 @@ config BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1
>  	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>  	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
>  	select BR2_INSTALL_LIBSTDCPP
> -	select BR2_LARGEFILE
>  	select BR2_INET_IPV6
>  	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
>  	select BR2_USE_WCHAR
> @@ -800,7 +797,6 @@ config BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1
>  	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>  	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
>  	select BR2_INSTALL_LIBSTDCPP
> -	select BR2_LARGEFILE
>  	select BR2_INET_IPV6
>  	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
>  	select BR2_USE_WCHAR
> @@ -818,7 +814,6 @@ config BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2
>  	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>  	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
>  	select BR2_INSTALL_LIBSTDCPP
> -	select BR2_LARGEFILE
>  	select BR2_INET_IPV6
>  	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
>  	select BR2_USE_WCHAR
> @@ -885,7 +880,6 @@ config BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC_2014_12
>  	depends on BR2_HOSTARCH = "x86_64"
>  	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
>  	select BR2_INSTALL_LIBSTDCPP
> -	select BR2_LARGEFILE
>  	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
>  	select BR2_ENABLE_LOCALE
>  	select BR2_USE_WCHAR
> @@ -1151,14 +1145,6 @@ endchoice
>  
>  if BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC
>  
> -config BR2_TOOLCHAIN_EXTERNAL_LARGEFILE
> -	bool "Toolchain has large file support?"
> -	select BR2_LARGEFILE
> -	help
> -	  Select this option if your external toolchain supports
> -	  largefile. If you don't know, leave the default value,
> -	  Buildroot will tell you if it's correct or not.
> -
>  config BR2_TOOLCHAIN_EXTERNAL_INET_IPV6
>  	bool "Toolchain has IPv6 support?"
>  	select BR2_INET_IPV6
> -- 
> 2.0.5
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'


More information about the buildroot mailing list