[Buildroot] [PATCH 1/1] package/Makefile.in: Do not add --enable-debug flag.

Johan Oudinet johan.oudinet at gmail.com
Thu Mar 12 13:01:07 UTC 2015

Thomas, All,

On Wed, Mar 11, 2015 at 9:42 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
>> -ifeq ($(BR2_ENABLE_DEBUG),y)
>> -ENABLE_DEBUG := --enable-debug
>> -else
>> +ifneq ($(BR2_ENABLE_DEBUG),y)
>>  ENABLE_DEBUG := --disable-debug
>>  endif
> So if we have BR2_ENABLE_DEBUG enabled, then we don't pass
> --disable-debug. And when BR2_ENABLE_DEBUG is disabled, we're passing
> it. I'm not sure to understand the logic here.
> Shouldn't we simply unconditionally pass --disable-debug, or not pass
> anything at all?

I felt bad in passing --disable-debug when BR2_ENABLE_DEBUG is set,
and I didn't want to remove it otherwise (in case a package expects
it). Still, the result is not logic. Actually, there is no good reason
for a package to depends on a --disable-debug flag to produce a
version without debugging information (see for example
I'm going to remove --disable-debug too.

> Also, a number of packages had workarounds in their specific .mk file
> to avoid --enable-debug. It would be good to get rid of such
> workarounds as well.

Indeed, I'm going to get rid of such workarounds and send another
version for this patch.
Thanks for the quick review.

Johan Oudinet

More information about the buildroot mailing list