[Buildroot] [PATCH] openpgm: Blacklist Blackfin ADI 2014R1 toolchain
romain.naour at openwide.fr
Sun Mar 8 16:43:48 UTC 2015
Le 08/03/2015 08:53, Thomas Petazzoni a écrit :
> Dear Romain Naour,
> On Sat, 7 Mar 2015 19:51:55 +0100, Romain Naour wrote:
>> Openpgm requires compiler intrinsics not available with Blackfin ADI toolchains.
>> Signed-off-by: Romain Naour <romain.naour at openwide.fr>
>> package/openpgm/Config.in | 1 +
>> 1 file changed, 1 insertion(+)
>> diff --git a/package/openpgm/Config.in b/package/openpgm/Config.in
>> index 3a26212..8d03c84 100644
>> --- a/package/openpgm/Config.in
>> +++ b/package/openpgm/Config.in
>> @@ -1,6 +1,7 @@
>> config BR2_PACKAGE_OPENPGM
>> bool "openpgm"
>> # The following toolchains lack required compiler intrinsics
>> + depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1
>> depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1
>> depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2
>> depends on BR2_TOOLCHAIN_HAS_THREADS
> When you add a new dependency to a symbol, you need to propagate this
> dependency to the other symbols select that one. In this specific case,
> zeromq PGM support was selecting openpgm, so you need to replicate this
> dependency. I've applied after fixing that.
Ah yes, thanks.
I completely forgot to check that :/
> Also, at some point, we will need to really on the ARCH_HAS_ATOMICS
> stuff for this.
really -> rely
You mean BR2_ARCH_HAS_ATOMICS ?
But it's set by default for bfin configs.
If I understand correctly, you want to move those "denpends on" to Config.in.bfin:
# The following toolchains lack required compiler intrinsics
depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1
depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1
depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2
I can cook a patch to do that.
> Best regards,
More information about the buildroot