[Buildroot] [PATCH 4/5] package/efl/libevas: Switch to giflib

Fabio Porcedda fabio.porcedda at gmail.com
Sat Mar 7 17:01:41 UTC 2015


On Sat, Mar 7, 2015 at 5:32 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Fabio Porcedda,
>
> On Sat, 7 Mar 2015 17:29:56 +0100, Fabio Porcedda wrote:
>
>> IMHO it's cleaner if instead of adding this patch you can add a
>> post_patch hook that using sed change all "DGifCloseFile(gif)" to
>> "DGifCloseFile(gif, NULL)".
>
> I don't agree. Such sed expressions can very easily be overlooked when
> bumping the package, and they don't solve a problem that should be
> solved by submitting a patch to the upstream project.

I don't know exactly but the libevas seems dead, the last change in
the git repository was made 15 months ago.

https://git.enlightenment.org/legacy/evas.git/

I hope there is a chance for the patch to be accepted.

Bernd, have you tried to send the patch upstream?

Could you add a note in patch to justify the change?
Example:
>From http://giflib.sourceforge.net/gif_lib.html
GIF file openers and closers - DGifOpenFileName(),
DGifOpenFileHandle(), DGifOpen(), DGifClose(), EGifOpenFileName(),
EGifOpenFileHandle(), EGifOpen(), and EGifClose() - all now take a
final integer address argument. If non-null, this is used to pass back
an error code when the function returns NULL.

With above note added and because the sed option is not available:
Acked-by: Fabio Porcedda <fabio.porcedda at gmail.com>
Tested-by: Fabio Porcedda <fabio.porcedda at gmail.com>
[build fine the following defconfig:
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_EFL=y
BR2_PACKAGE_LIBEVAS=y
BR2_PACKAGE_LIBEVAS_GIF=y]

BR
-- 
Fabio Porcedda


More information about the buildroot mailing list