[Buildroot] [PATCH 2/2] samba4: bump to version 4.2.0
thomas.petazzoni at free-electrons.com
Fri Mar 6 09:26:32 UTC 2015
Dear Gustavo Zacarias,
On Fri, 06 Mar 2015 06:04:03 -0300, Gustavo Zacarias wrote:
> Well, i've done it several times in the past, just search for "While at
> it" and "Also" in the commit logs - in fact it was you who committed
> them in many cases (and not only mine).
> Does this mean that i should separate bumps from adding hash files
> and/or renaming patches?
There is obviously a line to draw between things that we can do in the
same commit, and things that we should not. I believe adding a hash
file together with a bump is OK since anyway doing the bump would
change the hash file.
> Because the workload and noise committing will go up higher if that's
> the choice.
> And how does a package style fix differ from renaming patches that's
> another style fix?
I'd say readability. Renaming patches is clearly separated from .mk
changes. In the case of your Samba 4.2 bump, the changes within the .mk
file are mixed between bump-related changes, and indentation-related
changes, and this is what bothers me.
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
More information about the buildroot