[Buildroot] [PATCH v3 2/2] logrotate: use pkg-config for the opt library

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Mar 4 22:29:09 UTC 2015


Dear Fabio Porcedda,

In the title: s/opt/popt/

On Sun,  1 Mar 2015 22:06:53 +0100, Fabio Porcedda wrote:
> Without using the pkg-config the dependencies are not included for a
> static linking so it fails to build.
> These failures are fixed by linking the libintl library that is a
> dependency of the opt library.

s/opt/popt/

I've fixed and committed. Though I have one concern below.


> +	$(MAKE) CC="$(TARGET_CC) $(TARGET_CFLAGS)" LDFLAGS="$(LDFLAGS)" \
> +		LOADLIBES="$(shell $(PKG_CONFIG_HOST_BINARY) --libs popt)" \

It's not currently supported in Buildroot, but LOADLIBES is extended by
the logrotate Makefile with -lacl or -lselinux when WITH_ACL or
WITH_SELINUX are used. I'm not sure this will play well with your
proposed solution.

But ok, this can be handled when/if someone adds ACL and/or SELinux
support to logrotate.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list