[Buildroot] [PATCH] board/acmesystems/arietta: new board

Angelo Compagnucci angelo.compagnucci at gmail.com
Tue Jun 30 10:05:20 UTC 2015


Hi Gustavo,

2015-06-30 0:25 GMT+02:00 Gustavo Zacarias <gustavo at zacarias.com.ar>:
>
>
> On 17/06/15 07:32, Angelo Compagnucci wrote:
>
>> This patch adds support to the Arietta board from Acmesystems.
>> This board comes in two memory sizes (128m and 256m) hence the
>> reason for two different configs.
>>
>> Signed-off-by: Angelo Compagnucci <angelo.compagnucci at gmail.com>
>
>
> Hi Angelo.
> A few nits:
>
>>   board/acmesystems/arietta/linux-4.0.config |  99 ++++++++++++++++
>
>
> Any particular reason you need a custom config instead of being able to use
> at91_dt (like on the Aria sample i sent)?
> I know the Arietta lacks an ethernet PHY, but the DTS should take care of
> that.

That configuration is really bloated, it compiles several unneeded
modules and it's not really optimized for arietta.

>> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="acme"
>
>
> Also the "acme" tag seems to be the "master" of customization (i.e. a moving
> target), could you switch to a commit hash?

Right, changing this for the next revision!

> Otherwise it looks OK without having hardware to test and you can have my
> Acked-by if you address these concerns.
> Thanks.
> Regards.

Thanks!

-- 
Profile: http://it.linkedin.com/in/compagnucciangelo


More information about the buildroot mailing list