[Buildroot] [PATCH 1/2] arch: tidy up mmu config
guido at vanguardiasur.com.ar
Wed Jun 3 14:12:54 UTC 2015
On Mon, Jun 01, 2015 at 10:09:32PM +0200, Arnout Vandecappelle wrote:
> On 05/21/15 18:54, Guido Martínez wrote:
> > Instead of blacklisting which architectures support MMUs (mandatorily
> > or optionally), introduce two Kconfig options that are selected by each
> > architecture in each case.
> > This simplifies the logic in BR2_USE_MMU.
> > Signed-off-by: Guido Martínez <guido at vanguardiasur.com.ar>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
> Two small improvements, but even without them this patch is OK for me.
> - In arch/Config.in, the ARM section and the Blackfin section look the same to
> the casual onlooker, but for ARM the MMU options depend on the subarchitecture,
> while for Blackfin it's always NOMMU. So I'd make this explicit by adding a
> comment for ARM:
> config BR2_arm
> bool "ARM (little endian)"
> # MMU support is set by subarchitectur in Config.in.arm
> Same for ELF in the second patch.
> - Like you did for ARM, I think you should move the MMU selection to the
> subarches for xtensa as well. Since in fact, the fsf variant is always MMU.
> So if you repost this patch and make the above changes, you can add my Acked-by.
Just resent the patches after applying these comments and the binfmt one
Thanks a lot for reviewing!
Guido Martínez, VanguardiaSur
More information about the buildroot