[Buildroot] [PATCH 4/4] br-reproduce-build: quote all variables

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sat Feb 14 21:10:46 UTC 2015

Dear Yann E. MORIN,

On Sat, 14 Feb 2015 11:52:06 +0100, Yann E. MORIN wrote:

> -wget -O ${BUILD_DIR}/config http://autobuild.buildroot.org/results/${BUILD_ID}/config
> +wget -O "${BUILD_DIR}/config http://autobuild.buildroot.org/results/${BUILD_ID}/config"

How can this work? You're putting both the -O argument and the URL
within the same quotes.

> -wget -O ${BUILD_DIR}/gitid http://autobuild.buildroot.org/results/${BUILD_ID}/gitid
> +wget -O "${BUILD_DIR}/gitid http://autobuild.buildroot.org/results/${BUILD_ID}/gitid"


Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering

More information about the buildroot mailing list