[Buildroot] [PATCH v2] qt-webkit-kiosk: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Feb 22 21:32:15 UTC 2015


Dear Jerome Oufella,

On Sat, 21 Feb 2015 23:22:00 -0500, Jerome Oufella wrote:
> Qt-webkit-kiosk is a simple browser working in kiosk-mode, powered by
> QtWebkit. It provides a convenient way to deploy a full-screen browser
> on embedded system platforms.
> 
> This commit adds the appropriate packaging to Buildroot, including an
> option to deploy the optional sound files.
> 
> Signed-Off-By: Jerome Oufella <jerome.oufella at savoirfairelinux.com>

Thanks for this new iteration.

Signed-Off-By: should be: Signed-off-by: ...

> diff --git a/package/qt-webkit-kiosk/Config.in b/package/qt-webkit-kiosk/Config.in
> new file mode 100644
> index 0000000..dd4b06f
> --- /dev/null
> +++ b/package/qt-webkit-kiosk/Config.in
> @@ -0,0 +1,20 @@
> +config BR2_PACKAGE_QT_WEBKIT_KIOSK
> +	bool "qt-webkit-kiosk"
> +	depends on BR2_PACKAGE_QT5
> +	select BR2_PACKAGE_QT5WEBKIT
> +	select BR2_PACKAGE_QT5MULTIMEDIA

I've done a test build, and there are some missing dependencies here.
You should also:

	select BR2_PACKAGE_QT5BASE_GUI
	select BR2_PACKAGE_QT5BASE_WIDGETS
	select BR2_PACKAGE_OPENSSL

QT5BASE_WIDGETS is not enabled by default, and is needed because
qt-webkit-kiosk uses the "printsupport" and qtwebkit widget modules,
which are only compiled if Qt5 widgets are enabled.

OpenSSL is mandatory because qt-webkit-kiosk uses QSslError
unconditionally.

I would have normally applied the patch myself and do the
proposed changes, but since I haven't had the time to finalize the
review, I thought I would simply point those issues to not forget about
them, so that you can send an updated version.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list