[Buildroot] [PATCH v7] wine: New package

Yann E. MORIN yann.morin.1998 at free.fr
Sun Feb 22 21:11:17 UTC 2015


Andre, All,

On 2015-02-22 21:57 +0100, André Hentschel spake thusly:
> >> +ifeq ($(BR2_TOOLCHAIN_EXTERNAL),y)
> >> +	WINE_CONF_OPTS += TARGETFLAGS="-b $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_PREFIX))"
> > 
> > We usually do not indent the variable assignements in conditional
> > blocks.
> 
> I've seen it that way (same goes for the dependencies checking) and i think it's much nicer that way...
> Is this minor enough to keep it that way?

Well, I'd prefer we don't indent, since we don't do that anywhere else
(well, there are a very few packages that do, but they are old, very
old; the rule is not to indent).

> > I'm doing a few test builds, and will respin an amended version of this
> > patch.
> 
> no need for a respin, your comments will simply end up in v8

OK, great!

Just respin it tonight if you don't have more comments shortly.
I know Thomas wanted to look at it and apply it soonish. :-)

Thanks!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'


More information about the buildroot mailing list