[Buildroot] [PATCH] pkg-cmake: reduce output when being silent

Fabio Porcedda fabio.porcedda at gmail.com
Thu Feb 12 21:20:08 UTC 2015


I've forgotten to do a replay all...

On Thu, Feb 12, 2015 at 6:24 AM, Fabio Porcedda
<fabio.porcedda at gmail.com> wrote:
> On Wed, Feb 11, 2015 at 9:14 PM, Thomas Petazzoni
> <thomas.petazzoni at free-electrons.com> wrote:
>> Dear Fabio Porcedda,
>>
>> On Wed, 11 Feb 2015 18:52:21 +0100, Fabio Porcedda wrote:
>>
>>> +ifdef QUIET
>>> +CMAKE_QUIET = -DCMAKE_RULE_MESSAGES=OFF -DCMAKE_INSTALL_MESSAGE=NEVER
>>> +else
>>> +CMAKE_QUIET =
>>> +endif
>>
>> Use:
>>
>> ifneq ($(QUIET),)
>> CMAKE_QUIET = -DCMAKE_RULE_MESSAGES=OFF -DCMAKE_INSTALL_MESSAGE=NEVER
>> endif
>>
>> We generally don't use ifdef to test the value of a variable in
>> Buildroot.
>
> Ok will change it, nevertheless I like more the "ifdef" but maybe it's
> just may personal preference.
>
>> The else part is unnecessary.
>
> I added that to be able to use "make --warn-undefined-variables", i
> was thinking that is a useful tool for debugging makefile code.
>
> BR
> --
> Fabio Porcedda



-- 
Fabio Porcedda


More information about the buildroot mailing list