[Buildroot] [PATCH v2] Add support for Flattened Image Trees

Thomas De Schampheleire patrickdepinguin at gmail.com
Thu Sep 18 14:14:09 UTC 2014


Hi Yegor,

On Thu, Sep 18, 2014 at 9:28 AM, Yegor Yefremov
<yegorslists at googlemail.com> wrote:
> On Thu, Sep 18, 2014 at 6:56 AM, Thomas De Schampheleire
> <patrickdepinguin at gmail.com> wrote:
>> Yegor Yefremov <yegorslists at googlemail.com> schreef:
>>>This patch provides an option to specify a FIT source
>>>file (*.its), that will usually be stored in a board directory,
>>>and the resulting blob file name (*.itb).
>>>
>>>Signed-off-by: Yegor Yefremov <yegorslists at googlemail.com>
>>>---
>>>Changes:
>>>       v2: moved configuration to fs infra instead of linux
>>>
>>> fs/Config.in     |  1 +
>>> fs/fit/Config.in | 28 ++++++++++++++++++++++++++++
>>> fs/fit/fit.mk    | 19 +++++++++++++++++++
>>> 3 files changed, 48 insertions(+)
>>> create mode 100644 fs/fit/Config.in
>>> create mode 100644 fs/fit/fit.mk
>>>
>>>diff --git a/fs/Config.in b/fs/Config.in
>>>index 5853113..8d882d0 100644
>>>--- a/fs/Config.in
>>>+++ b/fs/Config.in
>>>@@ -4,6 +4,7 @@ source "fs/cloop/Config.in"
>>> source "fs/cpio/Config.in"
>>> source "fs/cramfs/Config.in"
>>> source "fs/ext2/Config.in"
>>>+source "fs/fit/Config.in"
>>> source "fs/initramfs/Config.in"
>>> source "fs/iso9660/Config.in"
>>> source "fs/jffs2/Config.in"
>>>diff --git a/fs/fit/Config.in b/fs/fit/Config.in
>>>new file mode 100644
>>>index 0000000..add4d27
>>>--- /dev/null
>>>+++ b/fs/fit/Config.in
>>>@@ -0,0 +1,28 @@
>>>+config BR2_TARGET_ROOTFS_FIT
>>>+      bool "Flattened Image Tree support"
>>>+      help
>>>+        Compile a flattened image tree source into a flattened
>>>+        image tree blob. Select the *.its file to compile in the
>>>+        options below.
>>>+
>>>+if BR2_TARGET_ROOTFS_FIT
>>>+
>>>+config BR2_FIT_PATH
>>>+      string "Flattened Image Tree source file path"
>>>+      help
>>>+        Path to the image tree tree source files.
>>>+
>>>+config BR2_FIT_BLOB_NAME
>>>+      string "Flattened Image Tree blob file name"
>>>+      help
>>>+        File name for the resulting FIT blob.
>>
>> Two extra comments after sleeping over it:
>>
>> - is it really needed to ask for the blob file name? We
>>  could simply use the same file name as the source,
>>  but with modified extension.
>
> You're right, we can get rid of it or at least make it optional.
>
>> - I think we should add support for multiple fit images
>>  at once, which is not hard to do. The user would
>>  specify a space separated list of its files.
>
> O.K.
>
> But the first problem is, that cp command fails to execute because of
> missing quote. I've discussed this issue with  Thomas Petazzoni on IRC
> yesterday, but we couldn't see the problem. Could you try the patch
> and let me know, if it can be executed without any issues?

I see the same problem. It is caused by the fact that you have
multiple commands in ROOTFS_FIT_CMD, you should join them with '&& \'
at the end of each line.
I think you will then have to provide a default implementation for the
target_cmd ('true') to avoid a syntax error.

Also, I detected a missing dependency: you're using mkimage so you
should depend on host-uboot-tools I think.

Best regards,
Thomas


More information about the buildroot mailing list