[Buildroot] [PATCH 2/2] zeromq: add dependency on atomic operations

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Sep 8 09:33:05 UTC 2014


Dear Alexey Brodkin,

On Mon, 8 Sep 2014 09:27:21 +0000, Alexey Brodkin wrote:
> Hi Thomas,
> 
> On Mon, 2014-09-08 at 09:23 +0200, Thomas Petazzoni wrote:
> > Dear Alexey Brodkin,
> > 
> > On Mon,  8 Sep 2014 10:32:44 +0400, Alexey Brodkin wrote:
> > 
> > > diff --git a/package/cppzmq/Config.in b/package/cppzmq/Config.in
> > > index e17963e..9f32c51 100644
> > > --- a/package/cppzmq/Config.in
> > > +++ b/package/cppzmq/Config.in
> > > @@ -5,6 +5,7 @@ config BR2_PACKAGE_CPPZMQ
> > >  	depends on BR2_LARGEFILE # util-linux
> > >  	depends on BR2_USE_WCHAR # util-linux
> > >  	depends on BR2_TOOLCHAIN_HAS_THREADS # zeromq
> > > +	depends on BR2_ARCH_HAS_ATOMICS # zeromq
> > >  	select BR2_PACKAGE_ZEROMQ
> > >  	help
> > >  	  C++ binding for zeromq (ZeroMQ, 0MQ, zmq).
> > 
> > Same thing here: you should change the comment to *not* display it if
> > the architecture doesn't have atomic intrinsics.
> 
> I assume comments from the previous patch apply here as well, right?
> Especially since atomic ops are only used in "libpgm", i.e. if only
> BR2_PACKAGE_ZEROMQ_PGM is enabled.

If atomic operations are only used when BR2_PACKAGE_ZEROMQ_PGM is
enabled, why do we need to propagate all those dependencies then? If a
package selects BR2_PACKAGE_ZEROMQ and not BR2_PACKAGE_ZEROMQ_PGM,
there's no reason to propagate the dependency.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list