[Buildroot] Fwd: [PATCH v6 1/1] New package: openvmtools

Károly Kasza kaszak at gmail.com
Tue Sep 2 14:23:25 UTC 2014

I accidentally replied instead of reply-all.

---------- Forwarded message ----------
From: Károly Kasza <kaszak at gmail.com>
Date: Tue, Sep 2, 2014 at 3:59 PM
Subject: Re: [PATCH v6 1/1] New package: openvmtools
To: "Yann E. MORIN" <yann.morin.1998 at free.fr>

Hello Yann,

thanks for reviewing this patch!

> > +     bool "PAM support"
> > +     select BR2_PACKAGE_LINUX_PAM
> linux-pam depends on !static, so you should propagate the dependency
> here.

> linux-pam also depends on locales and wchar, but they re handled by the
> main symbols of openvmtools, so it is not needed to replicate them here.
> A comment might be OK, though:
>     # linux-pam needs locale and wchar, but we already have this
>     # dependency on the main symbol, above.

> Please add a comment saying why we need to autoreconf.
OK. (It's because the package is distributed without a configure script -
http://sourceforge.net/p/open-vm-tools/mailman/message/32550385/ )

> LDFLAGS="-L$(TARGET_DIR)/usr/lib"
> Why do you point to TARGET_DIR?
> Usually, we consider the development files are installed in STAGING_DIR.
> So, if you need to point to a library path, you should point to
> But STAGING_DIR/usr/lib is already searched for by our toolchain, so it
> should not be necessary to add it.
> If you really need that, explain why.

If I do not add -L$(TARGET_DIR)/usr/lib I simply get an error while

checking for getstat in -lprocps... no
checking for getstat in -lproc-3.2.8... no
checking for getstat in -lproc-3.2.7... no
configure: error: libproc not found. Please configure without procps (using
--without-procps) or install procps - http://procps.sourceforge.net
make: ***
Error 1

I don't know why, but I simply can not find any procps related libraries in
the staging directory:

scythe at buildroot-vm:~/buildroot/output$ find . | grep libproc
scythe at buildroot-vm:~/buildroot/output$ cd staging
scythe at buildroot-vm:~/buildroot/output/staging$ find . | grep libproc

> Ditto, STAGING_DIR/usr/include is already searched for by our toolchain,
> so it should not be needed.
> If you really need that, explain why.

If I omit the CUSTOM_DNET_CPPFLAGS variable, I get an error while

checking for dumbnet-config... no
checking for dnet-config... no
configure: error: dnet-config was not found on your PATH. Please configure
without dnet (using --without-dnet) or install dnet -
make: ***
Error 1

I think this is because the configure script is looking for a binary called
"dnet-config", and it needs the environment variable if the binary is not
found in the $PATH. So I guess this can't be circumvented.

I would send a new version, do you have any idea why procps-ng doesn't copy
it's libraries into the $(STAGING_DIR)?

Kind regards,
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140902/83316703/attachment.html>

More information about the buildroot mailing list