[Buildroot] [PATCH v3 5/5] package: linux-fusion: use install instead of cp
guido at vanguardiasur.com.ar
Tue Nov 18 19:40:06 UTC 2014
On Tue, Nov 18, 2014 at 08:23:43PM +0100, Arnout Vandecappelle wrote:
> On 18/11/14 18:17, Guido Martínez wrote:
> > Hi Arnout, all
> > On Mon, Nov 17, 2014 at 11:06:05PM +0100, Arnout Vandecappelle wrote:
> >> On 17/11/14 18:19, Guido Martínez wrote:
> >>> in order to not depend on the previous permissions of the file
> >>> Signed-off-by: Guido Martínez <guido at vanguardiasur.com.ar>
> >> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
> >> There are a few more suspicious cp instances:
> >> board/boundarydevices/nitrogen6x/post-build.sh
> >> boot/grub/grub.mk
> >> fs/iso9660/iso9660.mk
> > I'll take a look at these, thanks.
> >> Also, it would be good to document somewhere (e.g. in the intro mail) why the
> >> rsync in the toolchain is OK. Or even better, replace it even though it's not
> >> really necessary - it just feels more consistent and safe.
> > Yes, this sounds good. Maybe use --chmod on the toolchain and add a
> > comment there? This way we should be covered in the future if someone
> > uses 'rsync -a' from there.
> Actually the toolchain already uses --chmod=Du+w.
Yes, but that doesn't have any effect on files, so files under
output/staging can have just about any mode, and more so when the
toolchain is preinstalled somewhere.
Changing it to --chmod=u=rwX,go=rX would eliminate that variablity
(again, we're assuming that there are no 'random' exec bits set, but
that's reasonable since no files are created with the exec bit set).
This way, at any place within BR we could do 'rsync -a
$(STAGING_DIR)/... $(TARGET_DIR)/...' and have well-defined modes on the
That kind of rsync (or any other similar copy) don't exist as of now:
eveything is done via 'install'. So I don't have a strong opinion for
changing the rsync or not.
What do you guys think?
Guido Martínez, VanguardiaSur
More information about the buildroot