[Buildroot] [PATCH v3] faifa: new package
maxime.hadjinlian at gmail.com
Sun Jun 8 18:54:27 UTC 2014
Hi Thomas, Samuel,
Thanks a lot for your fixes.
On Sun, Jun 8, 2014 at 7:16 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Samuel Martin,
> On Sun, 8 Jun 2014 19:08:32 +0200, Samuel Martin wrote:
>> Just nit and late, but why do you need override the whole commands?
>> All of this could have been set in the FAIFA_INSTALL_TARGET_OPT
>> variable (respectively in FAIFA_INSTALL_STAGING_OPT):
>> FAIFA_INSTALL_TARGET_OPT = \
>> PREFIX=/usr \
>> STRIP=/bin/true \
>> DESTDIR=$(TARGET_DIR) \
>> Just nitpicking ;-)
> True. I believe it doesn't make a lot of difference in terms of code
> factorization, so to me, both solutions are almost equivalent.
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
More information about the buildroot